Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support milliseconds when constructing from a Date #726

Merged
merged 3 commits into from Oct 19, 2022

Conversation

prowe
Copy link
Contributor

@prowe prowe commented Oct 13, 2022

Issue #, if available: #725

This pull request modifies the constructor behavior to correctly handle a Date with non-zero milliseconds.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@popematt
Copy link
Contributor

popematt commented Oct 18, 2022

Thanks for finding and fixing this issue! It looks good, so after the ion-test-driver workflow finishes up (assuming there's no issues found), I'll go ahead and approve and merge this.

@popematt popematt linked an issue Oct 18, 2022 that may be closed by this pull request
@popematt
Copy link
Contributor

popematt commented Oct 18, 2022

FYI, @prowe, the ion-test-driver failure is unrelated to your changes. (Probably caused by amazon-ion/ion-test-driver#24.) I'm going to look into it a bit, but if I can't resolve it soon, I think it's safe to merge your change even though we don't have all the usual test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestamp from Date fails with non-zero milliseconds
2 participants