Add conditional export for cjs and es6 entry points #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems good to me. The Futhermore, the persistent failure seems to be related to python setup trouble not ion-js issues. |
jobarr-amzn
approved these changes
Feb 7, 2023
|
Created #742 based on failing PR workflow. |
|
This seems to not work in node, because ion-js's esm doesn't follow node's requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #740
Description of changes:
Added conditional
exportstopackage.jsonfor the CommonJS and ESModule builds respectively. See node docs on conditional exports.Tested the commonjs export by using my node REPL and noting that
require.resolve('ion-js')returnsnode_modules/ion-js/dist/commonjs/es6/Ion.js.Tested the es6 export by creating a small project containing the code snippet example from the Getting Started section of the README under
src/index.js, and usingrollupto build the project. In the tree shakennode_modulesgenerated byrollup, I can see onlyion-js/dist/es6/es6is preserved.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.