Fixes toJSON()
for Struct
to correctly return a dom.Value
instance
#752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #751
Description of changes:
This PR works on fixing
toJSON()
forStruct
to correctly return adom.Value
instance.Solution:
JSON.stringify()
usestoJSON()
if the object has that defined as per MDN:toJSON()
for struct was returning an object based on null object prototype which was giving incorrect results forinstanceof
when called inside theJSON.stringify
replacer function.Struct
's prototype to for the return object ontoSJON()
.List of changes:
Struct#toJSON()
now creates an object based on Struct's prototype instead of null object's prototype.Tests:
added a unit test to check for
instanceof dom.Value
insideJSON.stringify
replacer function.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.