Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module to load/dump standard protocol buffers #271

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

popematt
Copy link
Contributor

@popematt popematt commented Jul 5, 2023

Issue #, if available:

None

Description of changes:

Adds a module that provides functionality to make it easier to support standard protocol buffers in the benchmark CLI. Functionality includes:

  • Wrapper for a protocol buffer Message that provides load/loads and dump/dumps for that message type
  • Function to dynamically load a protocol buffer Message from a python module at runtime
  • Function to dynamically generate a protocol buffer Message from a proto file descriptor at runtime

The functions for loading the Message are important because we can't hard-code the Message implementation into the benchmark CLI (since it's not necessarily known at compile time), so we need some way to load them at runtime.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

amazon/ionbenchmark/proto.py Outdated Show resolved Hide resolved
@popematt popematt merged commit 82f7677 into amazon-ion:master Jul 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants