Removes dependency on ion-c-sys
#418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes all code that was previously behind the `ion_c` feature gate. Many of the native implementation APIs were developed with an eye towards maintaining compatability with the `ion-c-sys` implementation. However, this limited our ability to offer idiomatic APIs. `ion-hash` continues to have a dependency on `ion-c-sys` for the time being, but has been modified to depend on to the most recently published version of `ion-rust` that supported it. A follow-on PR will update `ion-hash` to depend on the native implementations instead.
Codecov Report
@@ Coverage Diff @@
## main #418 +/- ##
==========================================
- Coverage 88.49% 85.29% -3.21%
==========================================
Files 82 81 -1
Lines 14079 14367 +288
==========================================
- Hits 12459 12254 -205
- Misses 1620 2113 +493
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes all code that was previously behind the
ion_cfeature gate. Many of the native implementation APIs were developed with an eye towards maintaining compatability with theion-c-sysimplementation. However, this limited our ability to offer idiomatic APIs. Now thation-rust's native implementations are relatively complete, we can remove theion-c-sysdependency to facilitate refactoring.ion-hashcontinues to have a dependency onion-c-sysfor the time being, but it has been modified to depend on to the most recently published version ofion-rustthat supported it. A follow-on PR will updateion-hashto depend on the native implementations instead.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.