Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return to stable Rust now that 1.65 is released #446

Merged
merged 1 commit into from
Nov 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,10 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
# nightly can be very volatile--pin this to a version we know works well...
toolchain: nightly-2022-10-12
# Coverage requires the nightly toolchain because it uses the presently unstable `-Z profile` feature
# See: https://github.com/rust-lang/rust/issues/42524
# See also: https://github.com/actions-rs/grcov#usage
toolchain: nightly-2022-10-12 # nightly can be very volatile--pin this to a version we know works well
override: true
- name: Cargo Test
uses: actions-rs/cargo@v1
Expand Down
7 changes: 2 additions & 5 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,10 @@ jobs:
uses: actions-rs/toolchain@v1
with:
profile: minimal
# We're temporarily testing against `beta` to have access to GATs. When Rust v1.65 is released in
# 2022-11, we should change this back to `stable`.
# See: https://github.com/amzn/ion-rust/issues/443
toolchain: beta
toolchain: stable
components: rustfmt, clippy
override: true
- name: Cargo Build
- name: Cargo Build
uses: actions-rs/cargo@v1
with:
command: build
Expand Down
3 changes: 3 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ exclude = [
]
version = "0.14.0"
edition = "2021"
# We need at least 1.65 for GATs
# https://blog.rust-lang.org/2022/11/03/Rust-1.65.0.html
rust-version = "1.65"

[workspace]
members = [
Expand Down