Stop impl Display for Element from panicking on typed nulls #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #451 +/- ##
==========================================
+ Coverage 83.57% 83.94% +0.37%
==========================================
Files 87 87
Lines 16479 16479
==========================================
+ Hits 13772 13833 +61
+ Misses 2707 2646 -61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
zslayton
approved these changes
Dec 7, 2022
jobarr-amzn
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #450
Description of changes:
ion-teststo ensure thatDisplayis consistent with the defaultTextWriter.DisplayforElementso that it doesn't try to unwrapNone.format_struct(),format_list(), andformat_sexp()to be consistent with the output of aTextWriter(I removed some extra whitespace inside the containers), and updates the unit tests accordingly.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.