Clippy suggestions #470
Merged
Clippy suggestions #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
February 21, 2023 10:36
This patch updates out-of-date dependencies that could be upgraded without any additional logic or code changes. * `bigdecimal`: 0.2 -> 0.3 * `delegate`: 0.5 -> 0.9 * `num-bigint`: 0.3. -> 0.4 * `rstest`: 0.9 -> 0.16 `pretty-hex` (which was not being used) is no longer a dev dependency. `base64` and `bytes` remain outdated, but will require logic changes.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dep-updates #470 +/- ##
==============================================
Coverage ? 90.42%
==============================================
Files ? 77
Lines ? 14171
Branches ? 0
==============================================
Hits ? 12814
Misses ? 1357
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
desaikd
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on dependency updates made in PR #469.
Incorporates a few hundred
clippysuggestions. Also adds--testsflag to theclippy-checkCI Action so test code will be automatically evaluated in the future.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.