Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows empty one-line comments. #474

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Allows empty one-line comments. #474

merged 1 commit into from
Feb 28, 2023

Conversation

zslayton
Copy link
Contributor

Issue #, if available:
#425

Description of changes:
Modifies the comment parser to allow empty comments.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (2140858) 90.39% compared to head (6b9237f) 90.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
+ Coverage   90.39%   90.42%   +0.02%     
==========================================
  Files          77       77              
  Lines       14177    14179       +2     
==========================================
+ Hits        12816    12821       +5     
+ Misses       1361     1358       -3     
Impacted Files Coverage Δ
src/text/parsers/comments.rs 100.00% <100.00%> (ø)
src/text/non_blocking/raw_text_reader.rs 93.28% <0.00%> (+0.11%) ⬆️
src/text/parsers/timestamp.rs 90.31% <0.00%> (+0.38%) ⬆️
src/reader.rs 83.02% <0.00%> (+0.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zslayton zslayton merged commit 2e08499 into main Feb 28, 2023
@zslayton zslayton deleted the allow-empty-comments branch February 28, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants