-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes ion-hash
a feature of ion-rs
#478
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #478 +/- ##
=======================================
Coverage 90.14% 90.14%
=======================================
Files 76 77 +1
Lines 13568 13568
=======================================
Hits 12231 12231
Misses 1337 1337
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yessss 🚀
One question about optional dependencies below. If it's straightforward, can you address the clippy
warnings before merging? (With the exception of the redundant closure
warning, which is caused by issue #472.)
@@ -27,6 +27,10 @@ members = [ | |||
"ion-hash" | |||
] | |||
|
|||
[features] | |||
default = [] | |||
ion-hash = ["digest"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that the optional digest
dependency should be included when the ion-hash
feature is enabled? If so, should sha2
also be in this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that ion-hash
will automatically bring in digest
. I don't think it should bring in sha2
because sha2
is not required. Someone might want to use md5 or another hash function instead.
Issue #, if available:
Resolves #454
Description of changes:
ion-hash
from its own crate intoion-rs
ion-hash-tests
submodule to the root of the repoion-hash
crate to essentially tombstone the package.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.