Reduce 'pretty' indentation 4=>2 #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same indentation that `jq` uses by default for prettifying JSON, which makes like-for-like comparisons easiest. An indentation level of 4 also gets deep twice as fast as 2.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #523 +/- ##
=======================================
Coverage 88.90% 88.90%
=======================================
Files 81 81
Lines 12885 12885
=======================================
Hits 11455 11455
Misses 1430 1430
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
popematt
approved these changes
Apr 24, 2023
zslayton
approved these changes
Apr 24, 2023
almann
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: None.
Description of changes: This is the same indentation that
jquses by default for prettifying JSON, which makes like-for-like comparisons easiest. An indentation level of 4 also gets deep twice as fast as 2.Please feel free to discard this pull request if it's unwanted, consider it opening the conversation of "what kind of indentation should we use?"
I intend to add an
--indentoption such as the one thatjqsupports toion-cli, but I am here moving the default forpretty.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.