Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds CI matrix for crate features #533

Merged
merged 3 commits into from
Apr 26, 2023
Merged

Adds CI matrix for crate features #533

merged 3 commits into from
Apr 26, 2023

Commits on Apr 26, 2023

  1. Adds CI matrix for crate features 

    This change makes it so we build our crate with all the various
interesting permutations:

* *default* - build with no features set.
* `--all-features` - build with all the bells and whistles.
* `--features X` where `X` is:
  * `ion-hash`
  * `experimental`
  * `ion-hash,experimental`

When building/testing with these permutations, it uncovered a bug in the
`ion-hash` doc tests where the test code depends on an optional feature.
This has been conditionally compiled out, preserving the text of the
doc comment (only runs when the appropriate feature flag is enabled).

Also updates the build of API docs to error out on leaking internal
references.  This change cleans up such documentation comments.
    @almann
    almann committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    2510369 View commit details
    Browse the repository at this point in the history

  2. Update .github/workflows/rust.yml 

    Co-authored-by: Matthew Pope <81593196+popematt@users.noreply.github.com>
    @almann @popematt
    almann and popematt committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    ced5088 View commit details
    Browse the repository at this point in the history

  3. Removes build step as it is redundant

    @almann
    almann committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    f98c539 View commit details
    Browse the repository at this point in the history