Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a warning for ion-hash #535

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Conversation

almann
Copy link
Contributor

@almann almann commented Apr 26, 2023

When compiling only ion-hash with no sha2 feature, we get a warning that we import an unused digest::Output, this gates that import on the feature being enabled.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

When compiling only ion-hash with no `sha2` feature, we get a warning
that we import an unused `digest::Output`, this gates that import on
the feature being enabled.
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (448b1b2) 89.34% compared to head (c5dea31) 89.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #535   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          84       84           
  Lines       13284    13284           
=======================================
  Hits        11868    11868           
  Misses       1416     1416           
Impacted Files Coverage Δ
src/ion_hash/mod.rs 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@almann almann merged commit 65cb835 into amazon-ion:main Apr 26, 2023
18 checks passed
@almann almann deleted the ion-hash-warn branch April 26, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants