Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the "oldtime" feature of chrono #548

Merged
merged 2 commits into from
May 12, 2023

Conversation

tommy
Copy link
Contributor

@tommy tommy commented May 11, 2023

This feature, enabled by default in chrono versions <5, includes a dependency on the deprecated time@0.1.x. A security advisory is issued for this verion of time.

Some details available here: chronotope/chrono#602

The oldtime feature does not appear to be used by this crate. I verified tests pass locally for me. I hope you will consider merging this change, and thank your for your work on this project!

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This feature, enabled by default in chrono versions <5, includes a
dependency on the deprecated time@0.1.x. A security advisory is issued
for this verion of time. Some details available here:
chronotope/chrono#602
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (b8e8e82) 83.07% compared to head (a10284b) 83.07%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #548   +/-   ##
=======================================
  Coverage   83.07%   83.07%           
=======================================
  Files          83       83           
  Lines       16126    16126           
  Branches    16126    16126           
=======================================
  Hits        13396    13396           
  Misses       1566     1566           
  Partials     1164     1164           
Impacted Files Coverage Δ
src/binary/binary_writer.rs 62.87% <ø> (ø)
src/binary/decimal.rs 89.24% <ø> (ø)
src/binary/header.rs 0.00% <ø> (ø)
src/binary/int.rs 82.80% <ø> (ø)
src/binary/non_blocking/type_descriptor.rs 30.00% <ø> (ø)
src/binary/raw_binary_writer.rs 85.58% <ø> (ø)
src/binary/timestamp.rs 76.82% <ø> (ø)
src/catalog.rs 82.19% <ø> (ø)
src/element/builders.rs 90.19% <ø> (ø)
src/element/element_stream_reader.rs 74.17% <ø> (ø)
... and 28 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@almann almann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tommy for contributing this.

Looks good to me--I have added comments to provide context in the Cargo.toml for this, but will merge that in.

Cargo.toml Show resolved Hide resolved
Adds context around why this change is needed.
@almann almann merged commit ccc0e5a into amazon-ion:main May 12, 2023
17 of 18 checks passed
@tommy tommy deleted the omit-time-dependency branch May 12, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants