Disable the "oldtime" feature of chrono #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature, enabled by default in chrono versions <5, includes a dependency on the deprecated time@0.1.x. A security advisory is issued for this verion of time. Some details available here: chronotope/chrono#602
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
=======================================
Coverage 83.07% 83.07%
=======================================
Files 83 83
Lines 16126 16126
Branches 16126 16126
=======================================
Hits 13396 13396
Misses 1566 1566
Partials 1164 1164
☔ View full report in Codecov by Sentry. |
Adds context around why this change is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature, enabled by default in chrono versions <5, includes a dependency on the deprecated time@0.1.x. A security advisory is issued for this verion of time.
Some details available here: chronotope/chrono#602
The
oldtimefeature does not appear to be used by this crate. I verified tests pass locally for me. I hope you will consider merging this change, and thank your for your work on this project!By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.