Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes Int an opaque struct #571

Merged
merged 2 commits into from
Jun 16, 2023
Merged

Makes Int an opaque struct #571

merged 2 commits into from
Jun 16, 2023

Conversation

zslayton
Copy link
Contributor

The Int enum has been renamed to IntData and is now pub(crate).
A new opaque struct type called Int now wraps it.

Part of issue #507, related to merged PR #568.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The `Int` enum has been renamed to `IntData` and is now `pub(crate)`.
A new opaque struct type called `Int` now wraps it.
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 80.89% and project coverage change: +0.04 🎉

Comparison is base (c76655a) 83.23% compared to head (91fe9f9) 83.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   83.23%   83.27%   +0.04%     
==========================================
  Files         104      104              
  Lines       19611    19628      +17     
  Branches    19611    19628      +17     
==========================================
+ Hits        16323    16346      +23     
+ Misses       1750     1745       -5     
+ Partials     1538     1537       -1     
Impacted Files Coverage Δ
src/binary/non_blocking/raw_binary_reader.rs 80.91% <0.00%> (ø)
src/binary/uint.rs 92.30% <0.00%> (ø)
src/lazy/binary/raw/lazy_raw_value.rs 82.15% <ø> (ø)
src/text/parsers/containers.rs 97.53% <ø> (ø)
src/text/parsers/top_level.rs 92.20% <ø> (ø)
src/binary/raw_binary_writer.rs 85.33% <44.44%> (-0.07%) ⬇️
src/types/integer.rs 78.46% <76.08%> (+2.95%) ⬆️
src/lazy/binary/immutable_buffer.rs 87.02% <90.90%> (ø)
src/binary/int.rs 83.03% <92.85%> (+0.07%) ⬆️
src/binary/non_blocking/binary_buffer.rs 94.08% <100.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zslayton zslayton marked this pull request as ready for review June 16, 2023 16:47
@zslayton zslayton requested a review from popematt June 16, 2023 16:47
@zslayton zslayton merged commit 2953663 into main Jun 16, 2023
21 checks passed
@zslayton zslayton deleted the opaque-int branch June 16, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants