Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-hash cleanup #597

Merged
merged 3 commits into from
Jul 11, 2023
Merged

ion-hash cleanup #597

merged 3 commits into from
Jul 11, 2023

Conversation

zslayton
Copy link
Contributor

This PR:

  • Marks the ion-hash feature as experimental
  • Removes the old ion-hash subcrate from the workspace

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (2dc8a4a) 82.53% compared to head (3eb598b) 82.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #597      +/-   ##
==========================================
- Coverage   82.53%   82.53%   -0.01%     
==========================================
  Files         111      110       -1     
  Lines       19487    19486       -1     
  Branches    19487    19486       -1     
==========================================
- Hits        16083    16082       -1     
  Misses       1861     1861              
  Partials     1543     1543              
Impacted Files Coverage Δ
src/lib.rs 33.33% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zslayton zslayton marked this pull request as ready for review July 11, 2023 17:45
Copy link
Contributor

@popematt popematt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to make any changes to anything in the root README?

@zslayton
Copy link
Contributor Author

Do we need to make any changes to anything in the root README?

Good catch, there was a reference to the old feature name.

@zslayton zslayton merged commit 93dce09 into main Jul 11, 2023
18 checks passed
@zslayton zslayton deleted the make-ion-hash-experimental branch July 11, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants