Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comparison for cross representations in Int #640

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

desaikd
Copy link
Contributor

@desaikd desaikd commented Sep 6, 2023

Description of changes:
This PR fixes comparison for cross representation between i64 and BigInt which is used in Ordering implementation of Int.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Patch coverage is 92.35% of modified lines.

Files Changed Coverage
src/lazy/text/buffer.rs 89.53%
src/lazy/text/matched.rs 93.18%
src/types/integer.rs 94.11%
src/lazy/text/raw/reader.rs 100.00%

📢 Thoughts on this report? Let us know!.

@desaikd desaikd merged commit c72219d into main Sep 6, 2023
18 checks passed
@zslayton zslayton deleted the int-ordering branch October 16, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants