Stub out types for RawTextReader_1_1 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
approved these changes
Sep 11, 2023
| type Reader = LazyRawBinaryReader<'data>; | ||
| type Value = LazyRawBinaryValue<'data>; | ||
| type SExp = LazyRawBinarySExp<'data>; | ||
| type List = LazyRawBinaryList<'data>; | ||
| type Struct = LazyRawBinaryStruct<'data>; | ||
| type AnnotationsIterator = RawBinaryAnnotationsIterator<'data>; | ||
| // Macros are not supported in Ion 1.0 | ||
| type MacroInvocation = (); |
There was a problem hiding this comment.
question—instead of (), could you use ! here?
There was a problem hiding this comment.
I've done a version of that in the follow on PR in working on 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes superficial changes that affect a large number of lines of code:
TextEncodingtype intoTextEncoding_1_0andTextEncoding_1_1BinaryEncodingtoBinaryEncoding_1_0to make way for an eventualBinaryEncoding_1_1.This PR contains no logic changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.