Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes kludge import in integration test #710

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Removes kludge import in integration test #710

merged 2 commits into from
Feb 12, 2024

Conversation

zslayton
Copy link
Contributor

One of our integration tests imported a const definition of the Ion 1.0 version marker. This would lead to clippy complaining in non-test contexts (when the usage conditionally not compiled) that there was an unused import in the source.

This change eliminates the conditional import and just inlines the definition of IVM. Slightly repetitive, but better than a compile warning.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zslayton zslayton merged commit 4ea7b3b into main Feb 12, 2024
20 checks passed
@zslayton zslayton deleted the remove-import branch February 12, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants