Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Gradle 8 and use kover for code coverage #261

Merged
merged 1 commit into from
May 18, 2023

Conversation

popematt
Copy link
Contributor

@popematt popematt commented May 18, 2023

Issue #, if available:

Fixes #221

Description of changes:

Removes jacoco and adds kover. Had to upgrade Gradle to get it to work with Kover, so I upgraded from 6.x to 8.x. As a result, there are some minor changes that are seemingly unrelated. Basically, if "jacoco" is not in a particular part of the diff, then it's a change for upgrading to Gradle 8.

Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:

None

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.23 ⚠️

Comparison is base (3874427) 82.75% compared to head (62116f3) 80.53%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #261      +/-   ##
============================================
- Coverage     82.75%   80.53%   -2.23%     
============================================
  Files           116      116              
  Lines          3016     2959      -57     
  Branches        595      694      +99     
============================================
- Hits           2496     2383     -113     
- Misses          363      379      +16     
- Partials        157      197      +40     

see 84 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor Author

@popematt popematt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To upgrade Gradle, I ran gradle wrapper --gradle-version 8.1.1. I've noted which changes were done by the tool rather than by me so that you don't waste your time looking at them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ This file was modified automatically by the Gradle wrapper upgrade tool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ This file was modified automatically by the Gradle wrapper upgrade tool.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ This file was modified automatically by the Gradle wrapper upgrade tool.

@@ -38,7 +38,7 @@ dependencies {
}

application {
mainClassName = "com.amazon.ionschema.cli.MainKt"
mainClass.set("com.amazon.ionschema.cli.MainKt")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ mainClassName is removed in Gradle 8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ This file was modified automatically by the Gradle wrapper upgrade tool.

@@ -65,12 +65,13 @@ dokkaJavadoc.configure {
}

task sourcesJar(type: Jar) {
classifier 'sources'
archiveClassifier.set("sources")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗺️ classifier was also removed in Gradle 8.

@popematt popematt requested a review from jobarr-amzn May 18, 2023 21:13
@popematt popematt merged commit 9cbfe8d into amazon-ion:master May 18, 2023
4 of 5 checks passed
@popematt popematt deleted the kover branch May 18, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change from Jacoco to Kover for code coverage reports
2 participants