-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Gradle 8 and use kover for code coverage #261
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #261 +/- ##
============================================
- Coverage 82.75% 80.53% -2.23%
============================================
Files 116 116
Lines 3016 2959 -57
Branches 595 694 +99
============================================
- Hits 2496 2383 -113
- Misses 363 379 +16
- Partials 157 197 +40 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To upgrade Gradle, I ran gradle wrapper --gradle-version 8.1.1
. I've noted which changes were done by the tool rather than by me so that you don't waste your time looking at them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗺️ This file was modified automatically by the Gradle wrapper upgrade tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗺️ This file was modified automatically by the Gradle wrapper upgrade tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗺️ This file was modified automatically by the Gradle wrapper upgrade tool.
@@ -38,7 +38,7 @@ dependencies { | |||
} | |||
|
|||
application { | |||
mainClassName = "com.amazon.ionschema.cli.MainKt" | |||
mainClass.set("com.amazon.ionschema.cli.MainKt") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗺️ mainClassName
is removed in Gradle 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗺️ This file was modified automatically by the Gradle wrapper upgrade tool.
@@ -65,12 +65,13 @@ dokkaJavadoc.configure { | |||
} | |||
|
|||
task sourcesJar(type: Jar) { | |||
classifier 'sources' | |||
archiveClassifier.set("sources") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗺️ classifier
was also removed in Gradle 8.
Issue #, if available:
Fixes #221
Description of changes:
Removes
jacoco
and addskover
. Had to upgrade Gradle to get it to work with Kover, so I upgraded from 6.x to 8.x. As a result, there are some minor changes that are seemingly unrelated. Basically, if "jacoco" is not in a particular part of the diff, then it's a change for upgrading to Gradle 8.Related PRs in ion-schema, ion-schema-tests, ion-schema-schemas:
None
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.