Make marketplace id optional in GetOffersResult

amazon-php · Apr 25, 2023 · bed5123 · bed5123
1 parent 1a92bd9
commit bed5123
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/rector-php.php b/rector-php.php
@@ -20,6 +20,7 @@
 use AmazonPHP\SellingPartner\Model\ListingsItems\ListingsItemPutRequest;
 use AmazonPHP\SellingPartner\Model\Messaging\GetSchemaResponse;
 use AmazonPHP\SellingPartner\Model\Orders\Address;
+use AmazonPHP\SellingPartner\Model\ProductPricing\GetOffersResult;
 use AmazonPHP\SellingPartner\Model\Uploads\UploadDestination;
 use PHPStan\Type\ArrayType;
 use PHPStan\Type\BooleanType;
@@ -109,6 +110,11 @@
     $config->ruleWithConfiguration(
         AddReturnTypeDeclarationRector::class,
         [
+            new AddReturnTypeDeclaration(
+                GetOffersResult::class,
+                'getMarketplaceId',
+                new UnionType([new NullType(), new StringType()]),
+            ),
             new AddReturnTypeDeclaration(
                 CatalogItem::class,
                 'getAttributes',

diff --git a/src/AmazonPHP/SellingPartner/Model/ProductPricing/GetOffersResult.php b/src/AmazonPHP/SellingPartner/Model/ProductPricing/GetOffersResult.php
@@ -257,7 +257,7 @@ public function validate() : void
     /**
      * Gets marketplace_id.
      */
-    public function getMarketplaceId() : string
+    public function getMarketplaceId() : ?string
     {
         return $this->container['marketplace_id'];
     }