Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Amazon SP API models to the latest version #558

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

jasonhebert
Copy link
Contributor

Change Log

Added

Fixed

Changed

  • Add Jetbrains .idea directory to .gitignore.
  • Add user flag to Docker run commands in bin/generate.sh so files created are owned by the user/group running the operation.
  • Increase rector parallel processing timeout from 2 minutes to 10 minutes.
  • Update Amazon SP API models to the latest version

Removed

  • Remove Order Approvals API from SDK as it has been removed from the library.

Deprecated

Security


Description

  • Removed Order Approvals API from SDK as it has been removed from the library.
  • Added the Jetbrains IDE .idea meta directory to .gitignore.
  • Added the --user flag to the Docker run commands in bin/generate.sh so files created are owned by the user/group running the operation instead of the root user.
  • Increased the rector parallel processing timeout from 2 minutes to 10 minutes as timeout limit was reached during processing.

Remove Order Approvals API from SDK as it has been removed from the library.
Add Jetbrains .idea directory to .gitignore.
Add user flag to Docker run commands in bin/generate.sh so files created are owned by the user/group running the operation.
Increase rector parallel processing timeout from 2 minutes to 10 minutes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently this ItemApprovals portion of the specification (models/orders-api-model/ordersV0.json) was added on 01/25/2023 by Gibran Waldron and then reverted on 05/17/2023 by Jack Evoniuk. This is an unfortunate trend with Amazon developers and these API specifications.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, when I was working with their APIs I experienced things that nobody should experience. But honestly, in this case I believe we can keep it as is. I mean, yeah we can go with another major release but if it's was reverted then I’m assuming that this API stopped working anyway.
What are your thoughts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally would leave it on the 5.x branch and version it as such. I can make a notation in the changelog when the new version is tagged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed 💪

.gitignore Outdated Show resolved Hide resolved
@norberttech norberttech merged commit a0dd449 into amazon-php:5.x Jan 24, 2024
3 checks passed
@jasonhebert jasonhebert deleted the 5.x-update_sp_api_models branch January 31, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants