Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make optional parameters nullable even when they have a default value #561

Merged

Conversation

jasonhebert
Copy link
Contributor

Change Log

Changed

  • Modified api.mustache template to make method parameters nullable if they are optional even if a default value is presented.

Description

Make optional parameters nullable even when they have a default value

@jasonhebert jasonhebert linked an issue Jan 30, 2024 that may be closed by this pull request
@norberttech
Copy link
Member

I absolutely love how we need to adjust so many things including post generated code just to correct mistakes of people hired by Amazon. Anyway, it looks good to me 💪

@jasonhebert jasonhebert merged commit e01da05 into amazon-php:5.x Jan 31, 2024
4 checks passed
@jasonhebert jasonhebert deleted the 5.x.make_optional_params_nullable branch January 31, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pageSize needs to be nullable for getReports nextToken
2 participants