Merge fa85950 into 28baa00

lerna.json

@@ -4,10 +4,10 @@
   "ignoreChanges": [
     "**/fixtures/**",
     "**/__tests__/**",
+    "**/__snapshots__/**",
     "**/test/**",
     "**/*.md"
   ],
   "npmClient": "yarn",
-  "useWorkspaces": true,
   "conventionalCommits": true
 }

measure-bundle-size/README.md

@@ -15,13 +15,16 @@ yarn add measure-bundle-size
 ```ts
 import {measureIterable, measure, type MeasureResult} from 'measure-bundle-size'
 
+type MeasureOptions = {
+  debug?: boolean
+  log?: (...args: any[]) => void
+  stats?: boolean | 'tree' | 'table'
+  workspaceFolder?: string
+  flowPattern?: RegExp
+}
+
 // Lazy async generator API
-type measureIterable = (input: string, fileName?: string | null, {
-    debug?: boolean
-    log?: (...args: any[]) => void
-    stats?: boolean | 'tree' | 'table'
-    workspaceFolder?: string
-}) => AsyncGenerator<MeasureResult>
+type measureIterable = (input: string, fileName?: string | null, MeasureOptions) => AsyncGenerator<MeasureResult>
 
 for await (const result of measureIterable(`code`, __filename, {
   debug: true,
@@ -33,12 +36,7 @@ for await (const result of measureIterable(`code`, __filename, {
 }
 
 // Promise API
-type measure = (input: string, fileName?: string | null, {
-    debug?: boolean
-    log?: (...args: any[]) => void
-    stats?: boolean | 'tree' | 'table'
-    workspaceFolder?: string
-}) => Promise<MeasureResult[]>
+type measure = (input: string, fileName?: string | null, MeasureOptions) => Promise<MeasureResult[]>
 
 const results = await measure(`code`, __filename, {
   debug: true,

measure-bundle-size/package.json

@@ -21,20 +21,23 @@
     "@babel/traverse": "^7.23.6",
     "bytes": "^3.1.0",
     "debug": "^4.3.2",
-    "escalade": "^3.1.1"
+    "escalade": "^3.1.1",
+    "sucrase": "^3.35.0"
   },
   "peerDependencies": {
     "esbuild": "^0"
   },
   "devDependencies": {
     "@ambarli/alias": "^0.0.0",
+    "@react-native/assets": "^1.0.0",
     "@types/bytes": "^3.1.1",
     "@types/debug": "^4.1.7",
     "@types/dedent": "^0.7.0",
     "@types/lodash": "^4.14.176",
     "@types/react": "^17.0.32",
     "date-fns": "^2.17.0",
     "dedent": "^0.7.0",
+    "lodash": "^4.17.21",
     "react": "^17.0.2",
     "react-inline-center": "^1.0.1",
     "sanitize.css": "^13.0.0",

measure-bundle-size/src/measure.ts

@@ -80,6 +80,26 @@ const peerExternalPlugin: esbuild.Plugin = {
   },
 }
 
+const stripFlowTypesPlugin = (
+  pattern = /\/node_modules\/(@react-native|react-native|react-native-linear-gradient)\/(.*)\.js$/
+): esbuild.Plugin => {
+  return {
+    name: 'flow',
+    setup(build) {
+      build.onLoad({filter: pattern}, async (args) => {
+        const source = await fs.readFile(args.path, 'utf8')
+        const {stripFlowTypes} = await import('./stripFlowTypes')
+        const output = stripFlowTypes(source.toString(), args.path)
+        const contents = output ?? ''
+        return {
+          contents,
+          loader: 'jsx',
+        }
+      })
+    },
+  }
+}
+
 type StatsOpt = boolean | 'tree' | 'table'
 
 type BundleResult = {
@@ -134,13 +154,15 @@ const bundle = async (
   {
     baseDir,
     projectPkgFile,
+    flowPattern,
     stats: statsOpt = false,
     cache: cacheOpt = false,
   }: {
     baseDir: string
     projectPkgFile?: string | void
     stats?: StatsOpt
     cache?: boolean
+    flowPattern?: RegExp
   }
 ): Promise<BundleResult> => {
   const bundleMark = timeMark<'bundle' | 'zip' | 'analyze'>()
@@ -164,6 +186,7 @@ const bundle = async (
     return {} as T
   })
 
+  // TODO: use current package path as the cache key
   const cacheKey =
     cacheOpt && rootPkg !== undefined && genCacheKey(rootPkg, entryInput)
   if (cacheOpt && cacheKey) {
@@ -196,9 +219,36 @@ const bundle = async (
     },
     outfile: '<bundle>.js',
     absWorkingDir: workingDir,
-    plugins: [builtinExternalPlugin, peerExternalPlugin],
+    plugins: [
+      builtinExternalPlugin,
+      peerExternalPlugin,
+      stripFlowTypesPlugin(flowPattern),
+    ],
+    conditions: ['production'],
+    resolveExtensions: [
+      // RN
+      '.ios.js',
+      '.android.js',
+      '.native.js',
+      // node
+      '.mjs',
+      '.cjs',
+      // defaults to .jsx,.js,.tsx,.ts,.css,.json
+      '.jsx',
+      '.js',
+      '.tsx',
+      '.ts',
+      '.css',
+      '.json',
+    ],
     loader: {
       '.node': 'binary',
+      // RN or web app may use static assets
+      '.jpeg': 'empty',
+      '.jpg': 'empty',
+      '.png': 'empty',
+      '.webp': 'empty',
+      '.gif': 'empty',
     },
     external,
     target: 'esnext',
@@ -300,6 +350,10 @@ type MeasureOptions = {
    * the path of the workspace folder
    */
   workspaceFolder?: string
+  /**
+   * the files pattern to strip flow types
+   */
+  flowPattern?: RegExp
 }
 
 /**
@@ -308,7 +362,7 @@ type MeasureOptions = {
 export async function* measureIterable(
   input: string,
   fileName?: string | null,
-  {debug, log, stats, cache, workspaceFolder}: MeasureOptions = {}
+  {debug, log, stats, cache, workspaceFolder, flowPattern}: MeasureOptions = {}
 ): AsyncGenerator<MeasureResult> {
   if (debug) {
     logger.enabled = true
@@ -335,7 +389,7 @@ export async function* measureIterable(
   parseMark.end('parse')
   logger(parseMark.print())
 
-  const bundleOpts = {baseDir, projectPkgFile, stats, cache}
+  const bundleOpts = {baseDir, projectPkgFile, stats, cache, flowPattern}
   for (const importInfo of result.imports) {
     const statement = input.substring(importInfo.start, importInfo.end)
     // await new Promise((resolve) => setTimeout(resolve, 500))

measure-bundle-size/src/stripFlowTypes.ts

@@ -0,0 +1,20 @@
+import {transform} from 'sucrase'
+
+/**
+ * Strip flow types from the given source code.
+ *
+ * Why sucrase is used instead of babel, bundle size of this package:
+ * - `sucrase`: 848kb -> 1.1mb
+ * - `@babel/core` (with `@babel/plugin-transform-flow-strip-types`): 848kb -> 5.7mb
+ */
+export function stripFlowTypes(source: string, filename?: string) {
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-unsafe-call
+  const result = transform(source, {
+    transforms: ['flow', 'jsx', 'imports'],
+    jsxRuntime: 'automatic',
+    production: true,
+    filePath: filename,
+  })
+  // eslint-disable-next-line @typescript-eslint/no-unsafe-return, @typescript-eslint/no-unsafe-member-access
+  return result.code
+}