Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Show the amber version used to compile the bash script in the top comment #181

Closed
Mte90 opened this issue Jun 12, 2024 · 1 comment · Fixed by #245
Closed

✨ Show the amber version used to compile the bash script in the top comment #181

Mte90 opened this issue Jun 12, 2024 · 1 comment · Fixed by #245
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Milestone
Amber 0.4.0-alpha

Comments

@Mte90
Copy link
Member

Mte90 commented Jun 12, 2024

So instead of # Written in [Amber](https://amber-lang.com/) you get # Written in [Amber](https://amber-lang.com/) 0.3.7-beta as example.
@b1ek
Copy link
Member

b1ek commented Jun 13, 2024

should be a relatively easy fix. clap's crate_version can be used for this

@Ph0enixKM Ph0enixKM changed the title [Feature] Show the amber version used to compile the bash script in the top comment ✨ [Feature] Show the amber version used to compile the bash script in the top comment Jun 16, 2024
@Ph0enixKM Ph0enixKM changed the title ✨ [Feature] Show the amber version used to compile the bash script in the top comment ✨ Show the amber version used to compile the bash script in the top comment Jun 16, 2024
@Ph0enixKM Ph0enixKM added this to the Amber 0.4.0-alpha milestone Jun 17, 2024
@Mte90 Mte90 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Jun 24, 2024
Mte90 added a commit to Mte90/Amber that referenced this issue Jun 26, 2024
@Mte90
feat(compile): add Amber version, fix amber-lang#181
a0b371a
@Mte90 Mte90 mentioned this issue Jun 26, 2024
Merged
Ph0enixKM added a commit that referenced this issue Jul 3, 2024
@Mte90 @Ph0enixKM
feat(compile): add Amber version, fix #181 (#245)
d158dbf 
* feat(compile): add Amber version, fix #181

* Update src/compiler.rs

Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>

* Update src/header.sh

Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>

* review

* fix(cargo): updated

* fix(chrono): no errors

* fix(compiler): added bash comment

* fix(compiler): empty space

---------

Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>
Mte90 added a commit to Mte90/Amber that referenced this issue Jul 3, 2024
@Mte90 @Ph0enixKM
feat(compile): add Amber version, fix amber-lang#181 (amber-lang#245)
cee30f2 
* feat(compile): add Amber version, fix amber-lang#181

* Update src/compiler.rs

Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>

* Update src/header.sh

Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>

* review

* fix(cargo): updated

* fix(chrono): no errors

* fix(compiler): added bash comment

* fix(compiler): empty space

---------

Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
Amber 0.4.0-alpha
Development

Successfully merging a pull request may close this issue.

feat(compile): add Amber version, fix #181 Mte90/Amber
3 participants
@Mte90 @Ph0enixKM @b1ek