distinguish function calls that appear on the same line #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ek
approved these changes
Jun 20, 2024
|
Maybe for code readability we can do something if the Bash generated is executed with Amber itself so can parse the Bash code and give more info. |
|
@Ph0enixKM @arapower could you take a look at this? |
Ph0enixKM
requested changes
Jun 27, 2024
There was a problem hiding this comment.
@akihiro17 Can you resolve conflicts? I'd merge this as soon as possible and then work on the code readability. This is an urgent level bug
akihiro17
force-pushed
the
distinguish-func-call-with-same-line
branch
from
747cf3c
to
da73523
Compare
|
@Ph0enixKM I have resolved the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add the
colto theinvocation_instanceso that Amber can distinguish function calls that appear on the same line.