Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amber 1.3.2 regression test failure against crystal 1.9.1 #1329

Closed
chenrui333 opened this issue Jul 17, 2023 · 5 comments
Closed

amber 1.3.2 regression test failure against crystal 1.9.1 #1329

chenrui333 opened this issue Jul 17, 2023 · 5 comments

Comments

@chenrui333
Copy link
Contributor

Description

While building crystal 1.9.1, it was found that amber 1.3.2 test failed

  Postinstall of ameba: make bin && make run_file
  Failed postinstall of ameba on make bin && make run_file:
  /usr/local/bin/shards build 
  Dependencies are satisfied
  Building: ameba
  Error target ameba failed to compile:
  Showing last frame. Use --error-trace for full trace.
  
  There was a problem expanding macro 'macro_4732366672'
  
  Code in /usr/local/Cellar/crystal/1.9.1/share/crystal/src/yaml/serialization.cr:188:7
  
   188 | {% begin %}
         ^
  Called macro defined in /usr/local/Cellar/crystal/1.9.1/share/crystal/src/yaml/serialization.cr:188:7
  
   188 | {% begin %}
  
  Which expanded to:
  
     75 |                   
     76 | 
   > 77 |                   __temp_722 =
                            ^
  Error: type must be Ameba::Severity, not (Ameba::Severity | Nil)
  
  make: *** [bin/ameba] Error 1

Steps to Reproduce

  1. [First Step]
  2. [Second Step]
  3. [and so on...]

Expected behavior: [What you expect to happen]

pass

Actual behavior: [What actually happens]

failed

Reproduces how often: [What percentage of the time does it reproduce?]

Additional Information

relates to Homebrew/homebrew-core#136821

@chenrui333
Copy link
Contributor Author

cc @crimson-knight

@Blacksmoke16
Copy link
Contributor

This isn't related to Amber. See crystal-ameba/ameba#372.

@chenrui333
Copy link
Contributor Author

@Blacksmoke16 thanks for the pointer, gonna try it now.

@crimson-knight
Copy link
Member

I'm going to close this issue out since it's unrelated to Amber.

Thank you @chenrui333 for your hard work maintaining Homebrew!

@chenrui333
Copy link
Contributor Author

np at all, just propose some build patch to fix CI as well as brew build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants