Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies: Look up Cookies is Set-Cookie header #135

Closed
1 task
eliasjpr opened this issue Jul 13, 2017 · 1 comment
Closed
1 task

Cookies: Look up Cookies is Set-Cookie header #135

eliasjpr opened this issue Jul 13, 2017 · 1 comment
Assignees
@eliasjpr
Labels
kind:bug
Projects
Amber Framework 2017

Comments

@eliasjpr
Copy link
Contributor

The current Cookies implementation is not parsing the Set-Cookie header. See https://github.com/Amber-Crystal/amber/blob/master/src/amber/router/cookies.cr#L43

Basically we should be implementing/adding this https://github.com/crystal-lang/crystal/blob/3c3d3e2b830e81de0aa39b7af0cd6f82f759c410/src/http/cookie.cr#L150

Acceptance Criteria

  • Have the fill_from_headers load cookies from Set-Cookies
@eliasjpr eliasjpr self-assigned this Jul 13, 2017
@eliasjpr
Copy link
Contributor Author

Fixed with #138

@faustargz faustargz added this to Done in Framework 2018 Mar 17, 2018
@faustargz faustargz added this to Done in Framework 2018 May 5, 2018
@faustargz faustargz removed this from Done in Framework 2018 Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliasjpr eliasjpr

Labels
kind:bug
Projects
No open projects
Amber Framework 2017
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eliasjpr @faustargz