Support YAML::Serializable #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blacksmoke16
added
kind:feature
and removed
kind:breaking-change
kind:enhancement
labels
drujensen
approved these changes
Jul 17, 2018
|
@Blacksmoke16 wow, very cool! |
|
An update on this, am going to skip adding docs for this for now. Plan on dealing with #223 by making a directory to split-up our README into one topic per file and will write up docs for YAML then. |
|
@Blacksmoke16 looks like this will need some manual intervention to bring up to date with the json stuff. |
|
rip. I'll take a look when i get home. EDIT: @robacarp They were simple, fixed it real quick. |
robacarp
approved these changes
Jul 19, 2018
spec/granite_spec.cr
Outdated
| describe "YAML" do | ||
| context ".from_yaml" do | ||
| it "can create an object from YAML" do | ||
| yaml_str = %({"name": "yaml::anyReview","upvotes": 2, "sentiment": 1.23, "interest": 4.56, "published": true}) |
There was a problem hiding this comment.
should this be more classical yaml instead of basically json?
|
Thanks @Blacksmoke16 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprise! Is branched off of #253 so needs that first.
I'll need to edit the README again, probably use same examples as the JSON, but say it could also be YAML.
EDIT: Since we didnt have this feature before i updated the labels.