Revert .is_a?(JSON::Any)
#262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drujensen
reviewed
Jul 23, 2018
| @@ -122,7 +122,7 @@ module Granite::Fields | |||
| when "{{_name.id}}" | |||
| if "{{_name.id}}" == "{{PRIMARY[:name]}}" | |||
| {% if !PRIMARY[:auto] %} | |||
| @{{PRIMARY[:name]}} = value.is_a?(JSON::Any) ? value.raw.as({{PRIMARY[:type]}}) : value.as({{PRIMARY[:type]}}) | |||
There was a problem hiding this comment.
Can you provide a better explanation? Why do the other types not need it?
There was a problem hiding this comment.
This was added in #221 to parse the primary key value from JSON::Any.
Since we are using JSON::Serializable now, we don't define our own .from_json thus JSON::Any never reaches this anymore.
This should have been changed back in #253 with the removal of the rest of the JSON::Any typings, but i missed this one.
drujensen
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this logic when adding JSON::Serializable support.