Crystal v0.30.0 changes #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drujensen
force-pushed
the
crystal-v0.30.0
branch
from
88815fb
to
51aeb95
Compare
Crystal has a deprecation warning that causes the build to fail. Disabling `--error-on-warnings` for now.
drujensen
commented
Aug 3, 2019
| @@ -2,7 +2,7 @@ version: '2' | |||
| services: | |||
| spec: | |||
| build: . | |||
| command: 'bash -c "cd /app/user && bin/ameba && crystal tool format --check && crystal spec --warnings all --error-on-warnings"' | |||
There was a problem hiding this comment.
crystal's URI.unescape is generating a warning. disabling this for now.
drujensen
commented
Aug 3, 2019
| @@ -1,8 +1,8 @@ | |||
| export PG_DATABASE_URL=postgres://granite:password@localhost:5432/granite_db | |||
There was a problem hiding this comment.
docker-compose now automatically loads the .env file
|
Waiting for will/crystal-pg#178 to be merged and released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is waiting for a mysql and pg driver releases