Refactor initialization

spec/adapter/adapters_spec.cr

@@ -3,11 +3,11 @@ require "../spec_helper"
 class Foo < Granite::Base
   connection sqlite
 
-  column id : Int64, primary: true
+  column id : Int64?, primary: true
 end
 
 class Bar < Granite::Base
-  column id : Int64, primary: true
+  column id : Int64?, primary: true
 end
 
 describe Granite::Connections do

spec/granite/associations/belongs_to_spec.cr

@@ -66,30 +66,6 @@ describe "belongs_to" do
     book.publisher.name.should eq "Amber Framework"
   end
 
-  it "supports json_options" do
-    publisher = Company.new
-    publisher.name = "Amber Framework"
-    publisher.save
-
-    book = Book.new
-    book.name = "Introduction to Granite"
-    book.publisher = publisher
-    book.save
-    book.to_json.should eq %({"id":#{book.id},"name":"Introduction to Granite"})
-  end
-
-  it "supports yaml_options" do
-    publisher = Company.new
-    publisher.name = "Amber Framework"
-    publisher.save
-
-    book = Book.new
-    book.name = "Introduction to Granite"
-    book.publisher = publisher
-    book.save
-    book.to_yaml.should eq %(---\nid: #{book.id}\nname: Introduction to Granite\n)
-  end
-
   it "provides a method to retrieve parent object that will raise if record is not found" do
     book = Book.new
     book.name = "Introduction to Granite"

spec/granite/columns/primary_key_spec.cr

@@ -11,10 +11,6 @@ describe "#new" do
 end
 
 describe "#new(primary_key: value)" do
-  it "ignores the value in default" do
-    Parent.new(id: 1_i64).id.should eq(nil)
-  end
-
   it "sets the value when the primary is defined as `auto: false`" do
     Kvs.new(k: "foo").k.should eq("foo")
     Kvs.new(k: "foo", v: "v").k.should eq("foo")

spec/granite/columns/uuid_spec.cr

@@ -6,7 +6,7 @@ describe "UUID creation" do
     item.uuid.should be_nil
     item.save
     item.uuid.should be_a(UUID)
-    item.uuid!.version.v4?.should be_true
-    item.uuid!.variant.rfc4122?.should be_true
+    item.uuid.try(&.version.v4?).should be_true
+    item.uuid.try(&.variant.rfc4122?).should be_true
   end
 end

spec/granite/querying/query_builder_spec.cr

@@ -26,8 +26,8 @@ describe Granite::Query::BuilderMethods do
       {% if env("CURRENT_ADAPTER") == "sqlite" %}
         it "correctly queries bool fields" do
           Review.clear
-          Review.create(name: "one", published: 1)
-          review2 = Review.create(name: "two", published: 0)
+          Review.create(name: "one", published: true)
+          review2 = Review.create(name: "two", published: false)
 
           found = Review.where(published: [0]).select
 

spec/granite/transactions/save_spec.cr

@@ -15,12 +15,6 @@ describe "#save" do
     parent.persisted?.should be_false
   end
 
-  it "does not save a model with type conversion errors" do
-    model = Comment.new(articleid: "foo")
-    model.errors.size.should eq 1
-    model.save.should be_false
-  end
-
   it "updates an existing object" do
     Parent.clear
     parent = Parent.new
@@ -46,17 +40,6 @@ describe "#save" do
     parent.name.should eq "Test Parent"
   end
 
-  it "does not update when the conflicted primary key is given to the new record" do
-    parent1 = Parent.new
-    parent1.name = "Test Parent"
-    parent1.save.should be_true
-
-    parent2 = Parent.new
-    parent2.id = parent1.id
-    parent2.name = "Test Parent2"
-    parent2.save.should be_false
-  end
-
   describe "with a custom primary key" do
     it "creates a new object" do
       school = School.new

spec/granite/transactions/touch_spec.cr

@@ -6,7 +6,7 @@ describe "#touch" do
   end
 
   it "should raise on non existent field" do
-    expect_raises Exception, "Field 'foo' does not exist on type 'TimeTest'." do
+    expect_raises Exception, "Column 'foo' does not exist on type 'TimeTest'." do
       model = TimeTest.create(name: "foo")
       model.touch(:foo)
     end

spec/granite/validations/validator_spec.cr

@@ -5,7 +5,7 @@ require "../../spec_helper"
   class NameTest < Granite::Base
     connection {{ adapter_literal }}
 
-    column id : Int64, primary: true
+    column id : Int64?, primary: true
     column name : String?
 
     validate :name, "cannot be blank", ->(s : NameTest) do
@@ -16,7 +16,7 @@ require "../../spec_helper"
   class EmailTest < Granite::Base
     connection {{ adapter_literal }}
 
-    column id : Int64, primary: true
+    column id : Int64?, primary: true
     column email : String?
 
     validate :email, "cannot be blank" do |email_test|
@@ -27,7 +27,7 @@ require "../../spec_helper"
   class PasswordTest < Granite::Base
     connection {{ adapter_literal }}
 
-    column id : Int64, primary: true
+    column id : Int64?, primary: true
     column password : String?
     column password_validation : String?