Add type restrictions to methods in Adapter::Base #437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are errors in adapters when compiling against Crystal built from master:
Error: abstract def Granite::Adapter::Base#clear(table_name) must be implemented by Granite::Adapter::Pg
Error: abstract def Granite::Adapter::Base#insert(table_name, fields, params, lastval) must be implemented by Granite::Adapter::Pg
Error: abstract def Granite::Adapter::Base#update(table_name, primary_name, fields, params) must be implemented by Granite::Adapter::Pg
Error: abstract def Granite::Adapter::Base#delete(table_name, primary_name, value) must be implemented by Granite::Adapter::Pg
For other adapters there are the same errors.
This PR fixes the problem. Because of subclasses already define all these methods with type restrictions, there should not be breaking changes.
Tested against:
(crystal-lang/crystal@7e0fdb0a)