Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add ameba linting to formatting ci job #490

Merged

Conversation

jphaward
Copy link
Contributor

@jphaward jphaward commented Oct 16, 2023

Currently ameba is not in the pipeline however is used when running the tests within Docker (command in the readme). It would be useful for these to be consistent.

I cannot test the pipeline changes locally so it may need tweaking once the workflow has been approved.

Copy link
Member

@crimson-knight crimson-knight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it failed on CI now that is does run Ameba. Which is fine, we can make another PR that resolves those

@crimson-knight crimson-knight merged commit f0cb31c into amberframework:master Oct 16, 2023
8 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants