Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grecaptcha not defined patch #394

Conversation

arslanmurtaza
Copy link

@arslanmurtaza arslanmurtaza commented Jun 18, 2021

Why and what is being done.
Grecaptcha not defined error was being raised occasionally so, added window.grecaptcha check to execute recaptcha ready method only if grecaptcha is present.

Pre-Merge Checklist

  • CHANGELOG.md updated with short summary

@grosser
Copy link
Collaborator

grosser commented Jun 18, 2021

why do you think it is not defined ?
... this will still not make recaptcha work, are you ok with that ?

@arslanmurtaza
Copy link
Author

@grosser I believe it is not defined due to network latency.
The recaptcha endpoint might take too much time to load, or if it might not load for some reason.

In such cases grecaptcha isn't defined.

@grosser
Copy link
Collaborator

grosser commented Jun 18, 2021

if it's not defined it won't work and give no indication on why it did not work, so how is this better ? / what is the problem with it currently showing an error (end users won't see it afaik) ?

@arslanmurtaza
Copy link
Author

Got your point, can you please let me know how can we make sure that grecaptcha is always loaded first before calling grecaptcha.ready?
We have rollbar setup on our project, and it raises error there occasionally.

@grosser
Copy link
Collaborator

grosser commented Jun 19, 2021

check for defined in a loop ?
... might be some bots triggering it, so not sure how it happens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants