Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug in ATK FOA Decoder Psycoshelf #75

Closed
gsenna opened this issue Sep 23, 2021 · 4 comments
Closed

Small bug in ATK FOA Decoder Psycoshelf #75

gsenna opened this issue Sep 23, 2021 · 4 comments
Assignees
Labels

Comments

@gsenna
Copy link

gsenna commented Sep 23, 2021

Hi,

Should line 94 of the ATK FOA Decoder Psycoshelf read as

wc = tan($PI * mFreq * inverseSamplesblock);

instead of

wc = tan(pi * mFreq * inverseSamplesblock);

?

Thanks!

@joslloand
Copy link
Contributor

@joslloand
Copy link
Contributor

@gsenna
Copy link
Author

gsenna commented Sep 25, 2021

Hi,

Thanks for the quick reply. Another issue seems to be that the filter becomes unstable depending on the samplesblock used. 128 works, but with values like 256 and 512 the amplitude blows up.

lossius added a commit that referenced this issue Nov 1, 2021
The filter remains unstable for frequencies above 500 Hz, and I
am not sure if it works correctly. Further testing is required.
@lossius
Copy link
Contributor

lossius commented Nov 4, 2021

I set up a new issue #78 to address the instability, and close this one.

@lossius lossius closed this as completed Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants