Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs #13

Merged
merged 34 commits into from
Dec 29, 2014
Merged

Docs #13

merged 34 commits into from
Dec 29, 2014

Conversation

swans-one
Copy link
Contributor

@wesleykendall Here is the pull request for docs. Like I said, I've been writing a lot of them. I still have one small section to finish, and I want to add some links in the quickstart documentation. I wanted to get this pull request out tonight, though.

@robdmc Once this is merged, there will be a pretty, readable version on readthedocs.org. Until then, though, you're welcome to read through the quickstart here if you were having any troubles.

@swans-one
Copy link
Contributor Author

@wesleykendall I've made all the docs. Feel free to review/comment.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 3553fcd on Wilduck:docs into * on ambitioninc:develop*.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling cfeaf8c on Wilduck:docs into * on ambitioninc:develop*.

@wesleykendall
Copy link
Contributor

@Wilduck any clue what the coverall messages are for?

@swans-one
Copy link
Contributor Author

Not really... I was trying to set up coveralls to work on this project, but I guess I didn't do it right?


To use Entity Event with django, first be sure to install it and/or
include it in your ``requirements.txt`` Then include
``'localized_recurrence'`` in ``settings.INSTALLED_APPS``. After it is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

entity_event

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! I may have copy pasted this section...

@wesleykendall
Copy link
Contributor

@Wilduck found two possible errors

@swans-one
Copy link
Contributor Author

@wesleykendall I'm good for this to be merged whenever you are.

@wesleykendall
Copy link
Contributor

@robdmc can you take a look? I'm good to merge these. @Wilduck I added ambition developers as a collaborator on this

medium=email_medium,
source=photo_source,
entity=all_users,
sub_entity_kindd=EntityKind.objects.get(name='user'),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sub_entity_kindd -> sub_entity_kind

@robdmc
Copy link

robdmc commented Dec 19, 2014

Hey Erik. This looks really good. Very well written. I had just a few comments addressing mostly typos. I'm happy for it to be merged whenever you feel it is ready.

Also... Wes was right. The abstraction provided here is really quite good.

@swans-one
Copy link
Contributor Author

@robdmc Thanks for all the comments. Definitely made some real improvements as a result of them. I think this is finally ready @wesleykendall

@swans-one
Copy link
Contributor Author

Actually, making one last change.

@swans-one
Copy link
Contributor Author

alright, good to go now.

swans-one added a commit that referenced this pull request Dec 29, 2014
@swans-one swans-one merged commit 6f2d7bd into ambitioninc:develop Dec 29, 2014
@swans-one swans-one deleted the docs branch December 29, 2014 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants