Fix tests for Postgres9.3 #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres9.3 doesn't have jsonb and so is incompatible with Django's jsonb.JSONField.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres9.3 doesn't have jsonb and so is incompatible with Django's
jsonb.JSONField.This was meaning the tests wouldn't even run for me (Ubuntu 14.04), even though all except 2 passed without change - I've skipped those two if Postgres isn't new enough. It's slightly fiddly to get the Postgres version, but I think I've done it a reasonable way that will work for all/most modern Djangos.