Skip to content

Commit

Permalink
Bug 1658587 [wpt PR 24957] - |request_initiator_site_lock = <opaque>|…
Browse files Browse the repository at this point in the history
… for the process-wide factory., a=testonly

Automatic update from web-platform-tests
|request_initiator_site_lock = <opaque>| for the process-wide factory.

The CL modifies URLLoaderFactoryParamsHelper::CreateForRendererProcess
so that it sets |request_initiator_site_lock| of the process-wide
factory to an opaque origin.  This change is based on
https://crbug.com/1105794 which shows that there are indeed no cases in
the wild where a process-wide factory is used with a non-opaque
initiator origin.  This intuitively makes sense - the process-wide
factory should only be used in frames that have not yet committed any
navigation and such frame should not (yet) have a non-opaque origin.

Additionally, thanks to the change described above, there is no longer a
need for site/eTLD+1 comparisons in VerifyRequestInitiatorLock nor for
SiteInstanceImpl::GetRequestInitiatorSiteLock.

Fixed: 1098938
Change-Id: I9e8b53139a2418636c84e783f86ea8d7be34eed9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274591
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797542}

--

wpt-commits: e9e85e67994df01673a8eb55c47d1b6f5eb6c18a
wpt-pr: 24957
  • Loading branch information
anforowicz authored and moz-wptsync-bot committed Aug 25, 2020
1 parent d9b99e4 commit 29b9bb2
Showing 1 changed file with 1 addition and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,7 @@
});

// www1 is cross-origin, so the HTTP response is CORB-eligible.
//
// TODO(lukasza@chromium.org): Once https://crbug.com/888079 and
// https://crbug.com/1098938 are fixed, we should use a cross-*origin*
// rather than cross-*site* URL below (e.g. s/hosts[alt]/domains/g).
// See also https://crbug.com/918660 for more context.
var src_prefix = "http://{{hosts[alt][www1]}}:{{ports[http][0]}}/fetch/corb/resources/sniffable-resource.py";
var src_prefix = "http://{{domains[www1]}}:{{ports[http][0]}}/fetch/corb/resources/sniffable-resource.py";
body = `window['${script_has_run_token}'] = true;`
script.src = src_prefix + "?type=" + mime_type + "&body=" + encodeURIComponent(body);
document.body.appendChild(script)
Expand Down

0 comments on commit 29b9bb2

Please sign in to comment.