[proofing] Add pagination for revision list #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvchitrapu
requested changes
Apr 1, 2023
|
Looks good. Thanks for updating the packages and moving to flask-sqlalchemy. We can paginate on search and replace pages as well. |
|
LGTM. Ship it after resolving conflicts and merging in #486. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The major change here is that we've migrated to
flask-sqlalchemy.flask-sqllachemyis standard in the Flask ecosystem and has useful features like pagination. In addition, useful extensions likeflask-debugtoolbarexpect it. However,flask-sqlalchemymust have access to the Flask application context and cannot be used outside of it, which means that a migration is "viral" -- if we migrate one part of the code to flask-sqlalchemy, it's worthwhile to migrate everything else as well.So, this PR also migrates all of our code to use flask-sqlalchemy. By doing so, we can clean up quite a bit of custom code related to SQLAlchemy session management, and we can also standardize our codebase to be consistent with other Flask applications and extensions.