Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show how to exclude individual files in the exclude example #663

Merged
merged 2 commits into from
Feb 5, 2019

Conversation

ngoldbaum
Copy link
Contributor

It took me about a half hour this morning to puzzle out how to exclude individual files because I didn't realize the example regex excludes only directories. It perhaps took me longer than others since I'm not terribly comfortable with regular expressions but I think this is a common enough desire (to exclude an enumerated list of files along with whole directories) that it should be in the example. Hope you agree 😄.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 861

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.658%

Totals Coverage Status
Change from base Build 858: 0.0%
Covered Lines: 2791
Relevant Lines: 3045

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 861

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.658%

Totals Coverage Status
Change from base Build 858: 0.0%
Covered Lines: 2791
Relevant Lines: 3045

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 8, 2019

Pull Request Test Coverage Report for Build 882

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 120 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.05%) to 91.612%

Files with Coverage Reduction New Missed Lines %
tests/test_black.py 53 92.07%
black.py 67 94.66%
Totals Coverage Status
Change from base Build 858: -0.05%
Covered Lines: 2796
Relevant Lines: 3052

💛 - Coveralls

README.md Outdated
| tests/data
)/
# exclude a few common directories as well as foo.py
# in the root of the project
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change! While you're at it, I think it would be good to have separate comments for the directories and the individual file. Each of those should say whether it applies to files/dirs anywhere or just at the top level (e.g., will this config exclude some_dir/foo.py as well as foo.py?).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, I think.

@JelleZijlstra JelleZijlstra merged commit 9d74928 into psf:master Feb 5, 2019
@JelleZijlstra
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants