-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conflict of pdfmake.js and lodash #29
Comments
actually took another look. pdfmake is using lodash 3.1.0, and note that lodash v3.1.0 is significantly behind the current version (4.5.1). but either way, the lodash library used in pdfmake should be strictly confined within the package. could you get this fixed? |
Thanks for pointing this out, we simply include the default built from pdfMake. On the other hand it might be fixed if you manually include the resources into your document and add the "loDash" resource after |
Got it. I'll try it out later today and let you know if it works. Thanks for getting back so quickly. |
any news? |
@maertz - I was wondering about some odd lodash behaviors. Yes, amcharts/pdfmake in front of lodash dependency overrides my app's lodash version. Putting (my newer or at least expected version) lodash after amcharts/pdfmake did override the old lodash version inside pdfmake. |
Hi, I encountered this issue recently as well! I ended up fixing it by removing pdfmake as a dependency (I wasn't using this feature), but it's worth noting that the latest versions of pdfmake have fixed this: bpampuch/pdfmake#443 |
First, thanks for making this tool set available. It's very handy!
I am experiencing some trouble integrating the pdfmake lib with my codebase. The main cause is the conflict between the use of
_
(underscore) in pdfmake.js and the use of_
in lodash.My specific problem is that it gives me an error that
zipWith
function does not exist when I call_.zipWith
function in my own code. Removingpdfmake.js
file resolves that conflict, but the pdf export functionality is no longer available.I didn't look closely into the
pdfmake.js
file, but my guess is that some use of_
in that file is leaked into the global namespace. It is a serious bug if this is the case.Could you take a look at it? Thanks a lot for the help!
The text was updated successfully, but these errors were encountered: