Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clobber a global _ variable if one exists #443

Merged
merged 1 commit into from
May 18, 2016

Conversation

pjungwir
Copy link
Contributor

This is a PR to fix Issue #276 . Now pdfmake tells lodash not to set the global _ variable, so you can use a different version of lodash, or underscore, or whatever.

Btw I'm not sure why there are differences here to the files in build. It seems strange to even have those under source control. I ran gulp to build and test my changes, so I guess that's how they got updated. Let me know if you'd like me to do anything else about those.

@nicoabie
Copy link

+1
It should be a warning in the docs otherwise. I've come into strange bugs because of the clobbering of my underscore lib.

@bhericher
Copy link

+1 I would like to use pdfmake with Pentaho Ctools, but there is conflict with the _

@bhericher
Copy link

I confirm that this PR solves my problem.
For those who are interested : https://github.com/bhericher/TableWithButtons

@lobo-tuerto
Copy link

+1

@prostoandrei
Copy link

When it will be merged? It's very important issue!

@bpampuch bpampuch merged commit 59202f5 into bpampuch:master May 18, 2016
@sankaran85
Copy link

whether this issue is fixed ?

@csvan
Copy link

csvan commented Sep 28, 2016

Was this included in 0.1.20? The problem still persists on that version.

EDIT: 0.1.20 was released before this merge, so no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants