Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using environment variables for sensitive information #14

Closed
tonydelanuez opened this issue Oct 2, 2018 · 4 comments
Closed

Comments

@tonydelanuez
Copy link
Contributor

Storing config information (API keys, passwords, etc.) could be troublesome if they're just plaintext on a .ini file. Maybe environment variables would be better - use os.environ.get() to fetch them and just check if they're None.

@Ragnoroct
Copy link

I can work on this. By chance do you have any suggestions for the name of this file? .env is the first that comes to my mind. Also, I'm assuming that this file will be added to .gitignore

@Ragnoroct
Copy link

I like this idea of having the environment file and not version controlling it. It allows contributors to save their information for testing but not have to worry about accidentally committing it.

@amcquade
Copy link
Owner

amcquade commented Oct 5, 2018

im not opposed to the change, but the .ini files arent source controlled since they are included in the .gitignore file, what makes having them as environment variables more secure?

@Ragnoroct
Copy link

I didn't realize that they were both ignored. To be honest I don't think it makes a difference. So I'm okay for not doing it.

@amcquade amcquade closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants