-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with more AMD loaders (notably curl.js) #1
Conversation
👍 The more the merrier. @jrburke, thoughts? |
Also, I'm less concerned about keeping all the exporting boilerplate together than I am about really easy merging w/ upstream and being more inclusive. |
I'm OK with this, but my primary concern is getting something that is usable for the upstream repo. We can do this merge in our branch but if some point underscore wants it all together in the same block, I am more amenable to going that route if it means getting the change included in their repo. But we might as well try for the code change we like best. @unscriptable if that sounds good, @rpflorence I'm +1 on the merge. I assume you will be doing it, but give a holler if you do not have the time -- be sure to generate the min file fresh after the merge and then ideally move the latest version tag to this new version. |
@jrburke do you think they would be amenable to a boilerplate-at-the bottom approach? That'd work too, of course. -- J |
@unscriptable I hope so, that is why I think we should do your pull request and lead with what we think is best and then let their feedback guide any final solution, but just wanted to see how bad it is for you if they decide not to go this route. As of right now I have not gotten any indication they are actually thinking of including an AMD call, just going on the past experience. |
@jrburke I've got a shim that users can pre-load if the underscore folks decide to do AMD, but insist on keeping the boilerplate at the top. It's not ideal, but it works. -- J |
Sounds good let's merge it. |
Better compatibility with more AMD loaders (notably curl.js)
I merged this in, updated underscore-min.js again for good measure and moved the latest 1.3.1 tag to this merged result. |
Thanks James! |
I'm just submitting this for review. I just moved the define() call to the bottom to prevent "early export". Ideally, all of the module-ish boilerplate would be together, so I wanted to move it all to the bottom, but then I figured I'd just do something that works and see what you guys had to say. Feedback appreciated! -- John