This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
Handle parse_event_xml doing I/O in the event loop #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, good thing I admitted to not reviewing :-P. Just let me know when you are ready to have it pushed out. |
👍 . I've been extra vigilant about testing but I didn't expect |
|
Yeah, SoCo is odd like that. Most properties will also request data from the speaker. |
|
Looks like it fixed the problem. |
|
Looks good on my end as well |
|
0.0.42 published 😊 |
|
Thanks. I'll bump core |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes home-assistant/core#48732
I'll update the SoCo PR as well : SoCo/SoCo#815