-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add an option to disable sort_dict_of_dict_by_value when adding results to a run #9
Comments
Hi Paul, The rationale behind forcing sorting is to prevent the users to forget about it, which could cause a wrong evaluation. I thought about adding an option to avoid sorting to add_multi to avoid useless computation. However, your problem poses a question about evaluating your lists as they are not ranked. Sorry if what I'm about to say seems obvious. scores=[s for s in range(len(doc_ids))][::-1] It seems pretty feasible to me. What do you think? Best, Elias |
Hi, Thanks for your answer. I’ll consider using |
Mind that |
Oh, ok, I misunderstood your first answer. So are you still considering
? |
I am, but I will probably make changes that do not solve your issue. |
Ok, I understand, thanks for your quick answers :) |
Hi -- guy with the weird feature requests here 😅 --
Motivation
You don’t want to ask, but, I have some use case where all the documents returned by my system have the same score, however the order matters!
And, when you
add_and_sort
documents to a run, you end up applyingsort_dict_of_dict_by_value
, which might reverse the order or completely shuffle the order of document ids:Solution
Obviously, my system could add a slightly negative number to preserve the order of documents, however, this is more of a pain to me than commenting this line.
The request
Would you be be willing to add an option to disable
sort_dict_of_dict_by_value
when callingadd_multi
?Thanks for the quick response on my other issues :)
The text was updated successfully, but these errors were encountered: