Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SKIP_TEST flag to ament_add_gmock() #143

Merged
merged 1 commit into from Jul 3, 2018
Merged

Add SKIP_TEST flag to ament_add_gmock() #143

merged 1 commit into from Jul 3, 2018

Conversation

greimela-si
Copy link
Contributor

Adds the SKIP_TEST flag to ament_add_gmock() and passes it to the internal test function.

Resolves #129.

@dirk-thomas dirk-thomas added the in review Waiting for review (Kanban column) label Jul 3, 2018
mikaelarguedas
mikaelarguedas approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@mikaelarguedas mikaelarguedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikaelarguedas
Copy link
Contributor

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@mikaelarguedas mikaelarguedas merged commit fd3d09b into ament:master Jul 3, 2018
@mikaelarguedas mikaelarguedas removed the in review Waiting for review (Kanban column) label Jul 3, 2018
@greimela-si greimela-si deleted the feature/add_skip_test_flag_to_ament_add_gmock branch July 4, 2018 06:34
@greimela-si greimela-si mentioned this pull request Jul 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelarguedas mikaelarguedas mikaelarguedas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@greimela-si @mikaelarguedas @dirk-thomas