Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build all tests and skip execution if not supported #342

Merged
merged 3 commits into from
Aug 2, 2018

Conversation

greimela-si
Copy link
Contributor

Until now some tests like display or visual tests were not built on machines that don't have the capabilities to execute them.
After the SKIP_TEST option for gmock tests has been added (ament/ament_cmake#143) we changed the behavior to always build all tests and to skip the test execution if they are not supported.

@esteve esteve added the in review Waiting for review (Kanban column) label Jul 30, 2018
@greimela-si
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjwwood wjwwood merged commit 62bddf8 into ros2:ros2 Aug 2, 2018
@wjwwood wjwwood removed the in review Waiting for review (Kanban column) label Aug 2, 2018
@Martin-Idel-SI Martin-Idel-SI deleted the feature/always_build_all_tests branch August 9, 2018 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants