Treat warnings as errors in pytests #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI builds with this would be good. |
|
As mentioned in a separate discussion, it might be better to make the default value OFF so it doesn't disrupt current users. If we do this, then we should go through all our packages and turn the feature on explicitly to get this in our CI builds (unless I'm missing something). The downside is that it's easy to forget to turn on for new packages. I don't feel strongly either way, so I can change the default if someone has a preference. |
jacobperron
added
in review
|
Imo sticking to defaults makes more sense. And if the calling code wants to escalate warnings then they should opt-in to that (same as e.g. the compiler flag with the same name). |
dirk-thomas
reviewed
May 17, 2019
This has the benefit of making deprecation warnings visible, which are not by default. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/pywarning_as_error
branch
from
a878a9a
to
73d7a6c
Compare
dirk-thomas
approved these changes
Jun 3, 2019
|
Linux CI: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has the benefit of making deprecation warnings visible, which are not by default.